Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add source text pronunciation. #7

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

twistios
Copy link
Contributor

@twistios twistios commented Nov 11, 2024

  • added pronunciation for source text
    • did not rename the other variable, but it would make sense (like pronunciationTarget)
  • improved test code
    • also fixes a crash when target is set to Language.AUTO

- added `pronunciationSource`
- property seems to be optional so only take it if it exists (default null)
- `entries` instead of `values`
- also disable `Language.AUTO` (would produce a crash because of require)
- added text output for new feature `pronunciationSource`
@therealbush therealbush merged commit 348a95c into therealbush:master Nov 12, 2024
@therealbush
Copy link
Owner

Looks good. thank you for the contribution.

@therealbush therealbush mentioned this pull request Nov 12, 2024
@twistios
Copy link
Contributor Author

Is it possible to create a new release with my changes included soon?

@twistios
Copy link
Contributor Author

Ok, the release was published. Thank you!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants