fix: revert sqlx from 0.8.2 to 0.7.4 to correct mysql and mariadb string conversion errors #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianheineman
force-pushed
the
revert-sqlx
branch
from
2e90e58 to
6b3b51e
Compare
|
Bencher Report| Branch | revert-sqlx |
| Testbed | localhost |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| postgres-embedded | 📈 view plot | 809,080,000.00 |
| postgresql-embedded | 📈 view plot | 826,640,000.00 |
| rusqlite | 📈 view plot | 4,556,100.00 |
| sqlite | 📈 view plot | 4,878,000.00 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #198 +/- ##
==========================================
+ Coverage 90.24% 93.92% +3.67%
==========================================
Files 93 93
Lines 11692 11716 +24
==========================================
+ Hits 10552 11004 +452
+ Misses 1140 712 -428 ☔ View full report in Codecov by Sentry. |
…ing conversion errors
brianheineman
force-pushed
the
revert-sqlx
branch
from
f5de33e to
b35a31d
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting sqlx to version 0.7.4 to address string handling bugs:
launchbadge/sqlx#3387
launchbadge/sqlx#3390