Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Raise exceptions when encountering errors in files. #467

Open
Qwerty-133 opened this issue Jun 27, 2023 · 0 comments · May be fixed by #479
Open

Raise exceptions when encountering errors in files. #467

Qwerty-133 opened this issue Jun 27, 2023 · 0 comments · May be fixed by #479

Comments

@Qwerty-133
Copy link
Contributor

The current behaviour of the set_key and get_key functions is to warn for invalid lines, that isn't very helpful when using this library to parse env files

A ignore_errors parameter can be added to these functions

TheGeeKing added a commit to TheGeeKing/python-dotenv that referenced this issue Aug 15, 2023
Changed:
- `sey_key` and `get_key` have now verbose parameter. Default verbose was True for `get_key`, so `sey_key` and `get_key` have True by default.
- `sey_key` use `with_warn_for_invalid_lines` so I added a verbose parameter to it which is by default True.
- `parse` was also using `with_warn_for_invalid_lines`, it will by default be using `self.verbose`

Resolve theskumar#467
TheGeeKing added a commit to TheGeeKing/python-dotenv that referenced this issue Aug 15, 2023
Changed:
- `sey_key` and `get_key` have now verbose parameter. Default verbose was True for `get_key`, so `sey_key` and `get_key` have True by default.
- `sey_key` use `with_warn_for_invalid_lines` so I added a verbose parameter to it which is by default True.
- `parse` was also using `with_warn_for_invalid_lines`, it will by default be using `self.verbose`

Resolve theskumar#467
@TheGeeKing TheGeeKing linked a pull request Aug 15, 2023 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant