Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Better handle failed prometheus server #8

Merged
merged 12 commits into from
Aug 31, 2023
Merged

Better handle failed prometheus server #8

merged 12 commits into from
Aug 31, 2023

Conversation

caryjpaepen
Copy link
Collaborator

@caryjpaepen caryjpaepen commented Aug 28, 2023 •
edited by thejuan
Loading

Testing

  • Added test to fail check when only server is unreachable.

github-actions[bot]
github-actions bot reviewed Aug 28, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version df7c3ac
Number of rules checked 0
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

@thejuan thejuan self-requested a review August 28, 2023 06:01
@thejuan thejuan merged commit 2928607 into main Aug 31, 2023
16 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@thejuan thejuan thejuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caryjpaepen @thejuan @caryttd