-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Cannot set property 'rejectUnauthorized' of undefined #146
Comments
I would strongly suggest adding a wss server test to the test suite using self-signed certificates created with the pem module. |
I've fixed this, and I'm ready to do another release, but I can't because of npm/npm#6547 |
Ok, I was able to get my npm issues fixed, and the new version 1.0.10 has been pushed. Thanks for reporting this so quickly! I actually had done some testing with TLS before publishing 1.0.9, using a modification of a test script that @johnbrady6 had posted on issue #105. However, in that script, instead of passing process.env.NODE_TLS_REJECT_UNAUTHORIZED = "0"; So I was consequently able to test the TLS connectivity without testing the passing of TLS options to WebSocketClient 😞 |
Ohh. I'm very surprised at node.js that it has such a sweeping global option like that. Definitely wouldn't use that myself. Thanks for fixing! |
The new version is causing this in my tls (wss) code:
Line 103 of WebSocketClient.js should be
config.tlsOptions = {}
instead of usingdelete
. @theturtle32The text was updated successfully, but these errors were encountered: