Speedup indefinite freeze tests #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 29, 2020 20:36
Added ExpiredMetadataError to function documentation where it seems to be missing. Corrected the refresh() documentation: ExpiredMetadataError can only happen when top level metadata does not need to be updated but is expired. If the metadata gets updated and is expired, the result will be a NoWorkingMirror with ExpiredMetadata inside it. Signed-off-by: Jussi Kukkonen <jkukkonen@vmware.com>
Instead of sleeping, mock time.time() so Updater thinks it lives in the future. Signed-off-by: Jussi Kukkonen <jkukkonen@vmware.com>
lukpueh
reviewed
Oct 30, 2020
Signed-off-by: Jussi Kukkonen <jkukkonen@vmware.com>
MVrachev
approved these changes
Oct 30, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
sleep()calls worth ~15 seconds from indefinite freeze tests. Instead mocktime.time()so Updater thinks it's running in the future.Also add mentions of ExpiredMetadataError in Updater docs