Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update tested and supported Python versions #966

Merged
merged 1 commit into from
Dec 16, 2019

Conversation

lukpueh
Copy link
Member

@lukpueh lukpueh commented Dec 13, 2019

Fixes issue #:
None.
Motivated by recent 3.4 build failures observed in #775 (comment), due to an update of the transitive dependency colorama, which dropped Python 3.4 support in its latest version.

Description of the changes being introduced by the pull request:

  • Drop 3.4 (due to end-of-life) and add 3.7 and 3.8 to tox, travis and appveyor configuration for automated testing.
  • Adapt classifiers in setup.py accordingly.
  • Add python_requires field in setup.py to reflect supported versions. This will prevent pip from trying to install tuf on a non-supported version.

Please verify and check that the pull request fulfills the following
requirements
:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

- Drop 3.4 (due to end-of-life) and add 3.7 and 3.8 to tox, travis
and appveyor configuration for automated testing.
- Adapt classifiers in setup.py accordingly.
- Add python_requires field in setup.py to reflect supported
versions. This will prevent pip from trying to install tuf on
a non-supported version.

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
@joshuagl
Copy link
Member

Not a maintainer, but this looks good to me.

Copy link
Contributor

@mnm678 mnm678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukpueh lukpueh merged commit fa62bc8 into theupdateframework:develop Dec 16, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants