Skip to content

Future-proof dynCalls #233

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 13, 2025
Merged

Future-proof dynCalls #233

merged 1 commit into from
Mar 13, 2025

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Mar 13, 2025

Closes TOOL-3700


PR-Codex overview

This PR focuses on refactoring the code to replace direct calls to Runtime.dynCall and Module.dynCall with a new makeDynCall function, enhancing the code's maintainability and readability.

Detailed summary

  • Replaced Runtime.dynCall with {{{ makeDynCall("v", "vars.callback") }}}() in SystemThreadingTimer.jslib.
  • Updated touchend and focusout event listeners in WebGLInputMobile.jslib to use makeDynCall.
  • Changed WebSocket callback calls in WebSocket.jslib to makeDynCall.
  • Removed checks for Runtime.dynCall in WebGLWindow.jslib and WebGLInput.jslib, simplifying the code.
  • Unified the callback invocation method across multiple functions in WebGLInput.jslib.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Mar 13, 2025

@0xFirekeeper 0xFirekeeper linked an issue Mar 13, 2025 that may be closed by this pull request
@0xFirekeeper 0xFirekeeper merged commit a4ebd59 into v5 Mar 13, 2025
4 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/dyncall-syntax branch March 13, 2025 16:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix non-future-proof invocations of Emscripten dynCalls
1 participant