Try to sort out the homs #1488
Merged
Try to sort out the homs #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
force-pushed
the
lg/compatibility
branch
from
66200cd
to
607c166
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1488 +/- ##
==========================================
+ Coverage 75.26% 75.31% +0.05%
==========================================
Files 354 354
Lines 112724 112732 +8
==========================================
+ Hits 84845 84908 +63
+ Misses 27879 27824 -55
|
lgoettgens
force-pushed
the
lg/compatibility
branch
from
6bc33b4
to
43078a9
Compare
|
why is Aqua unhappy? |
The persistent task test does not work with deved dependecies |
|
so just ignore it? |
|
Jup, should be fine. And even if not, we are not changing anything for oscar master here |
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. oscar-system/Oscar.jl#3667 (comment)
Alternative to and thus closes #1483.