Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Pinned dependency of chalk #79

Closed
ondrejsevcik opened this issue Sep 18, 2024 · 3 comments
Closed

Pinned dependency of chalk #79

ondrejsevcik opened this issue Sep 18, 2024 · 3 comments
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request good first issue Good for newcomers

Comments

@ondrejsevcik
Copy link

I've noticed that the chalk dependency is pinned to a specific version. It would make sense to specify it with the ^ range. That way, npm can dedupe the versions in the dependency graph.

vitest-fail-on-console/package.json

Line 57 in f1643ae

"chalk": "5.3.0"

@thomasbrodusch
Copy link
Owner

Thanks @ondrejsevcik !
I will push a PR to improve this 👍

@thomasbrodusch thomasbrodusch added enhancement New feature or request good first issue Good for newcomers dependencies Pull requests that update a dependency file labels Sep 25, 2024
thomasbrodusch added a commit that referenced this issue Sep 28, 2024
@thomasbrodusch
fix(#79): unpinned dependency of chalk
42024d1
@thomasbrodusch
Copy link
Owner

Fixed in 42024d1 @ondrejsevcik

@ondrejsevcik
Copy link
Author

Will this improvement be released?

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomasbrodusch @ondrejsevcik