Proposal to pin skin to bottom when maintaining aspect ratio on iPhone #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasokken
force-pushed
the
master
branch
3 times, most recently
from
9de8373 to
4e828eb
Compare
thomasokken
force-pushed
the
master
branch
2 times, most recently
from
46aa61c to
08de8bd
Compare
thomasokken
force-pushed
the
master
branch
2 times, most recently
from
f4fb1fa to
c205a40
Compare
thomasokken
force-pushed
the
master
branch
3 times, most recently
from
e37d203 to
f7a95f5
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than center the skin vertically, this PR pins the skin to the bottom of the screen when the user's preference is to maintain the aspect ratio. This is more comfortable/ergonomic as it is easier to reach all the buttons, particularly for users with smaller hands using compact skins.