Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

(feature) Should be possible to enable /debug/pprof without the additional logging #2709

Closed
hairyhenderson opened this issue Nov 22, 2024 · 2 comments · Fixed by #2710
Closed
Labels
enhancement New feature or request p2 Medium priority

Comments

@hairyhenderson
Copy link
Contributor

Requirements

Right now it's necessary to set debug: true to get the pprof endpoint to listen. We like to continuously profile everything with Alloy and Pyroscope, but I'd rather not have requests to /metrics//health/etc also be logged.

How about an enablePprof config item? I'll issue a quick PR for discussion, but thought you might have other ideas too...

@hairyhenderson hairyhenderson added enhancement New feature or request needs-triage A priority should be added to the issue labels Nov 22, 2024
@thomaspoignant thomaspoignant added p2 Medium priority and removed needs-triage A priority should be added to the issue labels Nov 22, 2024
@thomaspoignant thomaspoignant removed their assignment Nov 22, 2024
@thomaspoignant
Copy link
Owner

This is actually a good idea.
I think having an option enablePprof makes a lot of sense for continuous profiling.

I just would like to keep it enable in debug mode even if enablePprof is false.

@hairyhenderson
Copy link
Contributor Author

@thomaspoignant great - see #2710 😁

@kodiakhq kodiakhq bot closed this as completed in #2710 Nov 23, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request p2 Medium priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants