feat(pprof): Allow enabling pprof endpoint separately from debug flag #2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
✅ Deploy Preview for go-feature-flag-doc-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
thomaspoignant
approved these changes
Nov 23, 2024
There was a problem hiding this comment.
Thanks for this PR @hairyhenderson.
I just added a bit of documentation but except that it is perfect 👌
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2710 +/- ##
=======================================
Coverage 84.73% 84.73%
=======================================
Files 111 111
Lines 5162 5162
=======================================
Hits 4374 4374
Misses 624 624
Partials 164 164 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #2709
Closes issue(s)
Resolve #2709
Checklist
README.mdand/website/docs)