Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add pip>=19.2<20 support #92

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Add pip>=19.2<20 support #92

merged 1 commit into from
Jun 11, 2020

Conversation

fridex
Copy link
Collaborator

@fridex fridex commented Jun 11, 2020

Related Issues and Dependencies

LinkCollector was introduce in pip>=20.

This introduces a breaking change

  • Yes
  • No

@sefkhet-abwy sefkhet-abwy bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 11, 2020
@sesheta
Copy link
Member

sesheta commented Jun 11, 2020

Thanks for Opening the Pull Request.
I can assist you with following commands:
/retest : To Rerun the test checks.
/deploy : To deploy the commit in test environment.

@ghost
Copy link

ghost commented Jun 11, 2020

Build succeeded.

@fridex fridex changed the title Add pip==19.2 support Add pip>=19.2<20 support Jun 11, 2020
Copy link
Collaborator

@frenzymadness frenzymadness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand the background here but the code looks good. I'd merge it first so we can test the compatibility in our CI in #91

@fridex fridex merged commit e973b79 into thoth-station:master Jun 11, 2020
@fridex fridex deleted the pip-19.2 branch June 11, 2020 13:34
@sesheta
Copy link
Member

sesheta commented Jun 11, 2020

Successfully Merged.
Thanks for the contribution.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants