Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Run CI for the most latest pip #93

Merged
merged 1 commit into from
Jun 14, 2020
Merged

Run CI for the most latest pip #93

merged 1 commit into from
Jun 14, 2020

Conversation

fridex
Copy link
Collaborator

@fridex fridex commented Jun 11, 2020

This introduces a breaking change

  • Yes
  • No

@sefkhet-abwy sefkhet-abwy bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 11, 2020
@fridex
Copy link
Collaborator Author

fridex commented Jun 11, 2020

I'll rebase respecting #91 once ready.

latest might look ugly in the listing. Any suggestions welcome.

@ghost
Copy link

ghost commented Jun 11, 2020

Build succeeded.

@sesheta
Copy link
Member

sesheta commented Jun 11, 2020

Thanks for Opening the Pull Request.
I can assist you with following commands:
/retest : To Rerun the test checks.
/deploy : To deploy the commit in test environment.

@ghost
Copy link

ghost commented Jun 11, 2020

Build succeeded.

@frenzymadness
Copy link
Collaborator

Good idea. I don't think it looks ugly. It looks special because it is. I'll convert it to draft so it'll be obvious that it's not ready for merge.

@frenzymadness frenzymadness marked this pull request as draft June 11, 2020 13:21
@fridex fridex marked this pull request as ready for review June 11, 2020 14:06
@fridex
Copy link
Collaborator Author

fridex commented Jun 11, 2020

Rebased, discarding "draft label".

@ghost
Copy link

ghost commented Jun 11, 2020

Build succeeded.

@fridex fridex mentioned this pull request Jun 11, 2020
Merged
2 tasks
frenzymadness
frenzymadness approved these changes Jun 14, 2020
View reviewed changes
Copy link
Collaborator

@frenzymadness frenzymadness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. 28 jobs in CI is kinda big number but I think it's worth it.

@fridex fridex merged commit 3d311d8 into thoth-station:master Jun 14, 2020
@fridex fridex deleted the latest-pip branch June 14, 2020 16:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@frenzymadness frenzymadness frenzymadness approved these changes

@goern goern Awaiting requested review from goern goern is a code owner

@harshad16 harshad16 Awaiting requested review from harshad16 harshad16 is a code owner

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fridex @sesheta @frenzymadness