Cookiless Embed example #3
Conversation
|
|
||
| - **Node.js** (v16+ recommended) | ||
| - **pnpm / npm / yarn** | ||
|
|
There was a problem hiding this comment.
There is no codesandbox, please follow the template or use the npm run new-example utility
| @@ -0,0 +1,28 @@ | |||
| import js from '@eslint/js' | |||
There was a problem hiding this comment.
configure eslint globally for the repo
| @@ -0,0 +1,124 @@ | |||
| import { TextField, Typography, Button, Box, Paper } from "@mui/material"; | |||
There was a problem hiding this comment.
Again this tries to do a lot more than necessary. We should perhaps move this to starter.
| @@ -0,0 +1,47 @@ | |||
| import { ServerConfiguration, ThoughtSpotRestApi, createConfiguration } from "@thoughtspot/rest-api-sdk"; | |||
There was a problem hiding this comment.
Why would you have this on the client ? This will confuse people as they would then follow the pattern blindly.
Lets be supercareful of what we expose here. This is a backend API call and should be done as a separate node server.
There was a problem hiding this comment.
got it , the reason i did here is to keep this example independent, without a token service this wont work, but what you said makes sense, so what do u suggest here instead ? how can i get a token here ?
There was a problem hiding this comment.
@sastaachar There is an example for spotter-agent-embed. Probably add a api layer which runs the token fetches.
sastaachar
force-pushed
the
sastaachar/cookiless-embed
branch
from
d735026 to
1899496
Compare
| {tsLogo ? <img src={tsLogo} alt="ThoughtSpot Logo" /> : null} | ||
| <span>Cookie-less App Embed</span> | ||
| </span> | ||
| {isInitialized ? <AppEmbed /> : null} |
There was a problem hiding this comment.
replace "null" with "Loading..."
| thoughtSpotHost: THOUGHTSPOT_HOST, | ||
| }); | ||
| setIsInitialized(true); | ||
| }, []); |
There was a problem hiding this comment.
lets make the following 2 changes to the sdk:
- Make render wait for init.
- expose a new hook called
useInitto encapsulate this usage.
No description provided.