Resolved issue with exploit (#766) #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muro8248
approved these changes
Aug 26, 2022
GH0st3rs
pushed a commit
to GH0st3rs/routersploit
that referenced
this pull request
Sep 18, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
I have updated target_function within api_ros_default_creds.py in that I have replaced tcp_sock with tcp_client as it was returning a boolean value instead of tcp_client object because of which exception in Issue request ($766) happened. On fixing this there was another issue at library apiros_client.py where readstr function was checking for an empty string however the sk.recv method was returning None instead so added a check for None value.
Verification
Provide steps to test or reproduce the PR.
./rsf.pyuse creds/routers/mikrotik/api_ros_default_credsset target 192.168.1.1runChecklist