build(error): treat warnings as errors by default

threeal · Jun 27, 2023 · 5eea20f · 5eea20f
1 parent 986ee92
commit 5eea20f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -21,7 +21,6 @@ jobs:
         run: |
           cmake ${{ matrix.package }} \
             -B ${{ matrix.package }}/build \
-            -D CMAKE_CXX_FLAGS=-Werror \
             -D BUILD_TESTING=ON
 
       - name: Check code formatting
@@ -58,7 +57,6 @@ jobs:
           cmake ${{ matrix.package }} `
             -B ${{ matrix.package }}/build `
             -D CMAKE_CXX_COMPILER=cl `
-            -D CMAKE_CXX_FLAGS=/WX `
             -D BUILD_TESTING=ON
 
       - name: Build project

diff --git a/error/CMakeLists.txt b/error/CMakeLists.txt
@@ -3,9 +3,9 @@ cmake_minimum_required(VERSION 3.0)
 project(error)
 
 if(MSVC)
-  set(WARNING_FLAGS /permissive- /W4 /w14640 /EHsc)
+  set(WARNING_FLAGS /WX /permissive- /W4 /w14640 /EHsc)
 else()
-  set(WARNING_FLAGS -Wall -Wextra -Wnon-virtual-dtor -Wpedantic)
+  set(WARNING_FLAGS -Werror -Wall -Wextra -Wnon-virtual-dtor -Wpedantic)
 endif()
 
 include(cmake/CPM.cmake)