feat: modify Error::message to return std::string_view

threeal · Dec 25, 2023 · a7137d3 · a7137d3
1 parent 6780674
commit a7137d3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/include/errors/error.hpp b/include/errors/error.hpp
@@ -3,6 +3,7 @@
 #include <memory>
 #include <ostream>
 #include <string>
+#include <string_view>
 #include <utility>
 
 namespace errors {
@@ -27,7 +28,7 @@ class Error {
    * std::cout << err << std::endl;
    * @endcode
    */
-  std::string message() const;
+  std::string_view message() const;
 
   friend Error make(const std::string& msg);
 

diff --git a/src/error.cpp b/src/error.cpp
@@ -4,7 +4,7 @@ namespace errors {
 
 Error::Error(const std::shared_ptr<const std::string>& message_ptr) : message_ptr(message_ptr) {}
 
-std::string Error::message() const {
+std::string_view Error::message() const {
   if (!message_ptr) return "no error";
   return *message_ptr;
 }