Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Error: Simplify error::Error #16

Merged
merged 5 commits into from
Jun 23, 2023
Merged

Error: Simplify error::Error #16

merged 5 commits into from
Jun 23, 2023

Conversation

threeal
Copy link
Owner

@threeal threeal commented Jun 23, 2023 •
edited
Loading

This pull request simplifies the error namespace by making the following changes:

  • Changed Error from a class to a struct with public member accessibility.
  • Restored the Error constructor to accept a single message string.
  • Removed the Error::matches method.
  • Removed the ErrorPtr alias.
  • Renamed the make function to format.

@threeal threeal added the feat label Jun 23, 2023
@threeal threeal self-assigned this Jun 23, 2023
@threeal threeal changed the title Error: Simplified error::Error Error: Simplify error::Error Jun 23, 2023
@threeal threeal marked this pull request as ready for review June 23, 2023 11:41
@threeal threeal merged commit fd02f4c into main Jun 23, 2023
@threeal threeal deleted the simplified-error branch June 23, 2023 11:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@threeal threeal

Labels
feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@threeal