Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Error: Remove Inheritance of std::exception in Error Struct #33

Merged
merged 5 commits into from
Jul 8, 2023
Merged

Error: Remove Inheritance of std::exception in Error Struct #33

merged 5 commits into from
Jul 8, 2023

Conversation

threeal
Copy link
Owner

@threeal threeal commented Jul 8, 2023 •
edited
Loading

  • Update the compilation to use C++20 standard.
  • Remove the inheritance of std::exception in the Error struct.
  • Change the Error::message property to be constant.
  • Remove the constructor of the Error struct.
  • Closes Error: Make Error Struct Constructor Private #31.

@threeal threeal added the feat label Jul 8, 2023
@threeal threeal self-assigned this Jul 8, 2023
@threeal threeal changed the title Error: Make Error Struct Not Inherit std::exception Error: Remove Inheritance of std::exception in Error Struct Jul 8, 2023
@threeal threeal marked this pull request as ready for review July 8, 2023 03:00
Base automatically changed from error-make-func to main July 8, 2023 03:01
@threeal threeal merged commit 071bd37 into main Jul 8, 2023
@threeal threeal deleted the error-no-inherit-std-except branch July 8, 2023 03:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@threeal threeal

Labels
feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: Make Error Struct Constructor Private
1 participant
@threeal