Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Separate Format Components #88

Merged
merged 5 commits into from
Dec 24, 2023
Merged

Separate Format Components #88

merged 5 commits into from
Dec 24, 2023

Conversation

threeal
Copy link
Owner

@threeal threeal commented Dec 24, 2023

This pull request resolves #87 by introducing a format component that contains an errors_format target. The target itself contains an errors::format function and a fmt::formatter<errors::Error> implementation which is separated from the errors target.

This pull request also introduces a NOT_SUBPROJECT variable to allow the format component to know if the root project is not a subproject, allows the format component to build its test target.

@threeal threeal self-assigned this Dec 24, 2023
@threeal threeal added this to the Version 1.0.0 milestone Dec 24, 2023
@threeal threeal force-pushed the separate-format-components branch from ca7673d to 1fe1353 Compare December 24, 2023 16:40
@threeal threeal marked this pull request as ready for review December 24, 2023 16:41
@threeal threeal merged commit 366a308 into main Dec 24, 2023
6 checks passed
@threeal threeal deleted the separate-format-components branch December 24, 2023 23:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate Format Component
1 participant