New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Modify Ok and Error #6

Merged

threeal merged 3 commits into main from modify-ok-and-err

Dec 3, 2022

Owner

threeal commented Dec 3, 2022 •

edited

Loading

modify how ok and error works by:

moving ok and error from res::internal to res namespace.
force to create a new res::Ok instance instead of using constant (for simplicity).
replace res::ErrMsgPtr that was using std::shared_ptr<std::string> to just using std::string (for simplicity).
create res::Err struct to wrap error data and force to create a new res::Err instance instead of just passing the error message.

threeal added 3 commits

December 3, 2022 20:35


          store error message as optional instead of shared pointer for simplicity

9cda003


          use struct derived from std::string to represent error

0c499b1


          move ok and err from res::internal to internal

threeal merged commit bda6848 into main

threeal deleted the modify-ok-and-err branch

December 3, 2022 14:15

threeal mentioned this pull request

Version 0.1.0 Release #26

Merged

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet