gen/zap: Record all errors #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when appending/adding an object or array to a Zap encoder, there's a possibliity of failure. Previously, we were recording the first failure and returning. This changes the generated code to rely on `multierr` and collect all such failures into a single error. Resolves #367
mh-park
approved these changes
Aug 27, 2018
|
Zap won't log the objects if they fail to marshal. |
|
Going to merge and release this shortly if there are no objections. |
akshayjshah
approved these changes
Aug 28, 2018
This isn't quite true. It's entirely possible for implementations of Here, I think we're safe - everything is (eventually) primitive types, so none of these implementations can ever actually fail. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When appending/adding an object or array to a Zap encoder, there's a
possibliity of failure. Previously, we were recording the first failure
and returning.
This changes the generated code to rely on
multierrand collect allsuch failures into a single error.
Resolves #367