Only sample conns inserted into the conntrack table #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were sampling events related to broadcasts and multicasts that were never inserted into the conntrack table. Conntrack has protocol-specific handlers that may give some flows an early drop if tracking them doesn't make much sense. These events are now dropped, since they were cause unbounded growth in the internal bookkeeping BPF map. Another plus: the first packet of a flow no longer has an empty start timestamp!
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an important bugfix, any users are highly encouraged to upgrade.
Previously, we were sampling events related to broadcasts and multicasts
that were never inserted into the conntrack table. Conntrack has
protocol-specific handlers that may give some flows an early drop if tracking
them doesn't make much sense.
These events are now dropped, since they were cause unbounded growth in the
internal bookkeeping BPF map. Another plus: the first packet of a flow no
longer has an empty start timestamp!