Support for custom gunicorn workers #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way it is easy to use uvicorn.workers.UvicornH11Worker or any other custom worker for that matter.
|
I have the same problem as in fastapi/fastapi#680 ... this PR would help. |
|
Hi @tiangolo, do you have any comments on this pr? |
|
Thanks for your contribution @andreportela ! 🍰 So, this PR would add the config only for the Python 3.7 image, not for the others... but related to that, I realized that there was too much code duplication, so I refactored the whole setup of this repo to make it easier to add a change like this that affects all the images. Then on top of that, I added a new PR adding extra configs, docs, and tests, including this 🎉 Given that, I'll close this now, but thanks for your effort! 🚀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should make it is easy to use
uvicorn.workers.UvicornH11Workeror any other custom worker for that matter while still keeping backwards compatibility.