Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow give the hasura cli version #9

Merged
merged 1 commit into from
Jun 6, 2021

Conversation

jhonnybail
Copy link
Contributor

Issue:

  • Project is working with Hasura GraphQL Engine 2.0.0-alpha.10 but the hasura cli running the stable version.

Solution:

  • Can be given by environment variable the hasura cli version that need so for this was created the env HASURA_ENGINE_VERSION.

Copy link
Owner

@tibotiber tibotiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jonathan, this seems like a good idea, thanks for the PR 🙂. I have suggested some changes to the README. Please help me update that if you're ok and I'll merge. By the way, I'm not able to try it at the moment, please confirm if you have tested that it works for you. Cheers.

README.md Outdated Show resolved Hide resolved
@jhonnybail jhonnybail force-pushed the feat-choose-engine-version branch from 4396470 to 412074b Compare June 5, 2021 19:25
@jhonnybail jhonnybail requested a review from tibotiber June 5, 2021 19:30
@tibotiber tibotiber merged commit 0b36265 into tibotiber:master Jun 6, 2021
@tibotiber
Copy link
Owner

Thank you @jhonnybail, it's merged and released to the marketplace as v1.5

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants