fix: make sure to terminate running processes before launching app #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
cb1kenobi
approved these changes
Sep 24, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue for Xcode 16+ and
ti build(not happening with LiveView) where the app would launch in an corrupted state after an incremental build. It seems to be a Xcode 16 regression that can be fixed by making sure to terminate running processes before installing the new build.Reported by @Max87ZA via tidev/titanium-sdk#14121
Test case:
ti build -p iosExpected behavior: The new version is installed
Actual behavior: The app hangs in the old state or gets partially updated