Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(ios): added support for iOS 18 dark mode icons #14137

Closed

Conversation

AbdullahFaqeir
Copy link
Contributor

As mentioned this issue #14122, this was missing.

@dlewis23
Copy link
Contributor

We have to also update the _build.js file to add the dark and tinted icons. Also have tell it to not flatten against a white background. The dark mode icon is not suppose to have a background the system adds a gradient background automatically.

Attached is my _build.js file. I'm sure there is a better way to handle not flattening against a white background.

_build.js.zip

@hansemannn
Copy link
Collaborator

@dlewis23 You can do a PR to @AbdullahFaqeir's branch, then it appears here in the PR once that PR is merged :)

@dlewis23
Copy link
Contributor

@hansemannn I tried to make a PR to it, but Github desktop keeps giving me an error when I try and publish the PR which I have not been able to figure out yet.

@dlewis23
Copy link
Contributor

I can't do a PR to @AbdullahFaqeir branch, it gives an error every time, but somehow went down a loop and ended up making a new PR here on accident with the changes: #14138

@hansemannn
Copy link
Collaborator

Closing in favor of #14138 as it seems newer and have been developed together.

@hansemannn hansemannn closed this Nov 23, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants