make sure PCA steps works with many variables

NEWS.md

@@ -1,5 +1,7 @@
 # orbital (development version)
 
+* Fixed bug where PCA steps didn't work if they were trained with more than 99 predictors. (#82)
+
 # orbital 0.3.0
 
 * `orbital()` has gained `type` argument to change prediction type. (#66)

R/recipes-utils.R

@@ -51,5 +51,5 @@ pca_helper <- function(rot, prefix, all_vars) {
 }
 
 pca_naming <- function(x, prefix) {
-	gsub(paste0(prefix, "0"), prefix, x)
+	gsub(paste0(prefix, "0+"), prefix, x)
 }

tests/testthat/test-step_pca.R

@@ -33,6 +33,25 @@ test_that("step_pca works with more than 9 PCs", {
 	expect_equal(res, exp)
 })
 
+test_that("step_pca works with more than 100 PCs", {
+	skip_if_not_installed("recipes")
+
+	data <- lapply(1:1000, function(x) sample(0:1, 100, TRUE))
+	names(data) <- paste0("V", 1:1000)
+	data <- dplyr::as_tibble(data)
+
+	rec <- recipes::recipe(~ ., data = data) %>%
+		recipes::step_pca(recipes::all_predictors()) %>%
+		recipes::prep()
+
+	exp <- recipes::bake(rec, new_data = data)
+
+	res <- dplyr::mutate(data, !!!orbital_inline(orbital(rec)))
+	res <- res[names(exp)]
+
+	expect_equal(res, exp)
+})
+
 test_that("step_pca only calculates what is sufficient", {
 	skip_if_not_installed("recipes")