Survival helpers #893
Merged
Survival helpers #893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topepo
added a commit
to tidymodels/extratests
that referenced
this pull request
Feb 27, 2023
|
Could this be moved to {hardhat} instead? They would be helpful in {yardstick} which doesn't import/suggests {parsnip} |
|
After talking with @DavisVaughan about moving them to hardhat, he recommended putting them in a portable file that can be added to other packages via |
4 tasks
hfrick
reviewed
Mar 1, 2023
Co-authored-by: Hannah Frick <hfrick@users.noreply.github.com>
topepo
added a commit
to tidymodels/extratests
that referenced
this pull request
Mar 1, 2023
* additional unit tests for tidymodels/parsnip#893 * import survival * namespaces since functions are now not exported * updates from reviewer feedback
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move some code from tune to parsnip since we will relocate the IPCW code here. This PR has basic helper functions. Unit tests that require actual
Survobjects will be in extratests