-
Notifications
You must be signed in to change notification settings - Fork 91
survival time to binary conversion #973
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
I've updated the documentation to match the language in the current draft for the tidymodels.org articles. About the unit tests: I've moved them to a file name so that we have that correspondence to the R file name. It's neat to get around the dependency on the survival package for the test by just defining the structure but all the other functions in that file are tested in extratests already. Are you up for me moving the test to extratests so that we only have one place to find those tests? |
Sure, that would be good |
Cool, I'll do that and solve the merge conflict in NEWS. Once that's done, I'll merge this PR 👍 |
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
This exports three functions in the standalone file (one function is new). It exports them in a separate file that uses some razzle-dazzle from the sources for with::defer.
Unit tests are here; no more needed in extratests for the new function.