-
Notifications
You must be signed in to change notification settings - Fork 24
Add engine specific predictor encodings #51
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because that file is named to parallel `fit.R`, which is where `.fit_pre()` lives.
- Use existing pull/update helpers - Use a filter rather than a merge - Update name to `finalize_blueprint()`
Thanks! |
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes workflows aware of the new engine specific predictor encodings implemented in tidymodels/parsnip#319 and discussed in tidymodels/parsnip#290 (and elsewhere).
The main idea is that instead of adding a
blueprint
to a preprocessor in anew_action_
function, the blueprint argument is passed on and evaluated later, within.fit_pre()
in the new `update_model_encoding() function.The tests use a ranger model because it is more clear what the "right" values should be, but no ranger function is called within
.fit_pre()
(only parsnip functions).In one test, we have:
If we fix 🤞 the issue around one-hot encoding vs. indicator values, this should go to 5.