Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improve ranking function documentation #6233

Closed
hadley opened this issue Apr 15, 2022 · 0 comments · Fixed by #6352
Closed

Improve ranking function documentation #6233

hadley opened this issue Apr 15, 2022 · 0 comments · Fixed by #6352
Labels
documentation

Comments

@hadley
Copy link
Member

hadley commented Apr 15, 2022

  • Don't just define in terms of rank().
  • Explain the consequences of using min_rank() vs dense_rank() vs row_number() for filtering (i.e. what's the max and min number of rows you might get)
hadley added a commit that referenced this issue Jul 22, 2022
@hadley
Improve documentation of ranking functions
ac1b789 
Fixes #6233. Fixes #5943.
@hadley hadley mentioned this issue Jul 25, 2022
Merged
hadley added a commit that referenced this issue Aug 2, 2022
@hadley
Collection of documentation tweaks (#6352)
2bd4895 
* Document all overridden functions in setops topic, instead of relying on re-exports.
* Tweak topic titles and reorganise reference index. Fixes #6017.
* Better description of `count(name =)`. Fixes #5958.
* Improve documentation of ranking functions. Fixes #6233. Fixes #5943.
* Don't include "methods" found in base packages. Fixes #6326
* Polish across docs. Fixes #6205
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Collection of documentation tweaks tidyverse/dplyr
1 participant
@hadley