Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

⏪ Revert "transparent theme (#5018)" #6309

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -737,7 +737,6 @@ export(theme_sub_panel)
export(theme_sub_plot)
export(theme_sub_strip)
export(theme_test)
export(theme_transparent)
export(theme_update)
export(theme_void)
export(transform_position)
Expand Down
35 changes: 0 additions & 35 deletions R/theme-defaults.R
Original file line number Diff line number Diff line change
Expand Up @@ -501,41 +501,6 @@ theme_classic <- function(base_size = 11, base_family = "",
)
}

#' @export
#' @rdname ggtheme
theme_transparent <- function(base_size = 11, base_family = "",
header_family = NULL,
base_line_size = base_size / 22,
base_rect_size = base_size / 22,
ink = "black", paper = alpha(ink, 0)) {
force(ink)
# Based on theme_bw
theme_grey(
base_size = base_size,
base_family = base_family,
header_family = header_family,
base_line_size = base_line_size,
base_rect_size = base_rect_size,
ink = ink, paper = paper
) %+replace%
theme(
panel.background = element_blank(),
plot.background = element_blank(),
legend.background = element_blank(),
legend.key = element_blank(),
# theme_bw specifications
panel.border = element_rect(fill = NA, colour = col_mix(ink, paper, 0.20)),
# make gridlines dark, same contrast with white as in theme_grey
panel.grid = element_line(colour = col_mix(ink, paper, 0.92)),
# contour strips to match panel contour
strip.background = element_rect(
fill = col_mix(ink, paper, 0.85),
colour = col_mix(ink, paper, 0.20),
),
complete = TRUE
)
}

#' @export
#' @rdname ggtheme
theme_void <- function(base_size = 11, base_family = "",
Expand Down
11 changes: 0 additions & 11 deletions man/ggtheme.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions tests/testthat/_snaps/prohibited-functions.md
Original file line number Diff line number Diff line change
Expand Up @@ -213,10 +213,6 @@
[1] "base_size" "base_family" "header_family" "base_line_size"
[5] "base_rect_size"

$theme_transparent
[1] "base_size" "base_family" "header_family" "base_line_size"
[5] "base_rect_size"

$theme_void
[1] "base_size" "base_family" "header_family" "base_line_size"
[5] "base_rect_size"
Expand Down
92 changes: 0 additions & 92 deletions tests/testthat/_snaps/theme/theme-transparent-large.svg

This file was deleted.

Loading
Loading