Skip to content

Reimplement classes in S7 #6364

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 107 commits into
base: main
Choose a base branch
from
Open

Reimplement classes in S7 #6364

wants to merge 107 commits into from

Conversation

teunbrand
Copy link
Collaborator

@teunbrand teunbrand commented Mar 17, 2025 •
edited
Loading

This PR aims to fix a large part of #6352.

Briefly it implements the following S7 classes:

  • class_ggplot
  • class_ggplot_built
  • class_mapping
  • class_labels
  • class_theme

I've put in the usual extractors and replacers ([, [[, $ and their <- methods) for the ggplot/ggplot_built classes for backwards compatibility. The code internally now uses @ though, so that we can deprecate the usual extractors/replacers later.

teunbrand added 30 commits March 4, 2025 15:19
@teunbrand
add S7 as import
8bd9f31
@teunbrand
custom properties for theme elements
d54e464
@teunbrand
convert theme elements to S7 classes
91302e0
@teunbrand
adapt element definitions
8c199a1
@teunbrand
convert element_grob to S7 generic
202b80d
@teunbrand
replace merge_element by S7
df02b37
@teunbrand
implement $.element for backward compatibility
b038e8f
@teunbrand
Use S7 properties
09eef8d
@teunbrand
fix inherits() issues
62d8db4
@teunbrand
fix misc issues
27cdb73
@teunbrand
Revert "implement $.element for backward compatibility"
3bc0d63 
This reverts commit b038e8f.
@teunbrand
don't rely on element$prop
360c975
@teunbrand
move element properties
68fe80b
@teunbrand
convert margin to S7
8c3471e
@teunbrand
I liked index properties as an idea but apparently they print badly
9f69323
@teunbrand
adapt failing example
e4b870b
@teunbrand
import S7
0154671
@teunbrand
convert theme to S7
b4163e0
@teunbrand
Reimplement S3 <uneval> into S7 <mapping>
7fce100
@teunbrand
convert labels to S7
32ccdb2
@teunbrand
make S7 class_ggplot
032ca6a
@teunbrand
Use @ as accessor
c37317b
@teunbrand
double dispatch for ggplot_add()
90d644f
@teunbrand
Write methods for external generics as S7
0310be8
@teunbrand
backward compatibility for ggplot class
2607597
@teunbrand
Implement <ggplot_built> as S7
30b1118
@teunbrand
implement as.gtable methods
ef5db54
@teunbrand
rename mapping to class_mapping
206c394
@teunbrand
refine class_ggplot_built and related functions
53504c3
@teunbrand
also access ggplot_built slots with normal extractors
bbdc7a5
thomasp85
thomasp85 approved these changes May 26, 2025
View reviewed changes
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yunuuuu Yunuuuu mentioned this pull request May 28, 2025
Open
@teunbrand
Copy link
Collaborator Author

teunbrand commented Jun 5, 2025 •
edited
Loading

I think it is necessary to make ggplot() a S3 generic again. I have the following reasons:

  1. Extension have S3 methods for the S3 generic.
    • You cannot write S3 methods for an S7 generic.
    • There are too many extensions to force them all to use S7 right now.
  2. Unlike S3 ggplot_build(), which we plan to replace with S7 build_ggplot(), the ggplot() function is much more user-facing. I don't think we want to phase-out ggplot() for other function names.
  3. If people want to use S7 methods, they can register them for the S3 generic without any issues.

@teunbrand teunbrand mentioned this pull request Jun 5, 2025
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@thomasp85 thomasp85 thomasp85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ggplot2 4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@teunbrand @thomasp85