Skip to content

Fix reverse dependency issue with scale_backward_compatibility() #6475

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix a problem identified in #6469.

Briefly, the scale_backward_compatibility() fallback we used sometimes got handed scale = NULL, which I didn't anticipate. That change was introduced in #5946. Here, we inspect type to inform us what to do in that case.

@teunbrand teunbrand added this to the ggplot2 4.0.0 milestone May 22, 2025
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit 8f1054e into tidyverse:main May 23, 2025
13 checks passed
@teunbrand teunbrand deleted the revdep_scale_backward_compatibility branch May 23, 2025 09:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants