Skip to content

Tiptoe around na.value #6500

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jun 11, 2025
Merged

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix #6499.

The solution is the same as in #6474.
Reprex from the issue:

devtools::load_all("~/packages/ggplot2/")

ggplot(mpg, aes(displ, hwy, colour = drv)) +
  geom_point() +
  scale_colour_manual(
    values = structure(c(`4` = "blue", f = "red", r = "green"), class = "foobar"),
    na.value = "gray"
  )

Created on 2025-06-11 with reprex v2.1.1

Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment but otherwise LGTM

@teunbrand teunbrand merged commit 6741938 into tidyverse:main Jun 11, 2025
13 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revdep: strictness of na.value type in scales
2 participants