Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add digits argument to round_hms() and trunc_hms() #78

Closed
krlmlr opened this issue Nov 12, 2019 · 2 comments · Fixed by #92
Closed

Add digits argument to round_hms() and trunc_hms() #78

krlmlr opened this issue Nov 12, 2019 · 2 comments · Fixed by #92
Labels
tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day
Milestone
1.0.0

Comments

@krlmlr
Copy link
Member

krlmlr commented Nov 12, 2019

round_hms(digits = 1) would map to round_hms(secs = 0.1); round_hms(digits = -2) would map to round_hms(secs = 60) .
@krlmlr krlmlr added this to the 0.6.0 milestone Dec 31, 2019
@krlmlr krlmlr added the tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day label Jan 31, 2020
@hglanz
Copy link
Contributor

hglanz commented Jan 31, 2020

I'm tackling this for tidy-dev-day 2020. Will finish remotely.

First draft of changes are in forked repo, with error messages and documentation left to finish.

@krlmlr krlmlr modified the milestones: 0.6.0, 1.0.0 Jan 12, 2021
@krlmlr krlmlr mentioned this issue Jan 12, 2021
Merged
krlmlr added a commit that referenced this issue Jan 12, 2021
@krlmlr
Merge pull request #92 from tidyverse/f-78-digits
4e76d99 
- `round_hms()` and `trunc_hms()` gain `digits` argument (#78, @hglanz).
@github-actions
Copy link
Contributor

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Add digits argument to round_hms() and trunc_hms() tidyverse/hms
2 participants
@krlmlr @hglanz