Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move lubridate on top of timechange #1078

Merged
merged 14 commits into from
Nov 2, 2022
Merged

Move lubridate on top of timechange #1078

merged 14 commits into from
Nov 2, 2022

Conversation

vspinu
Copy link
Member

@vspinu vspinu commented Oct 31, 2022

  • CCTZ and cpp11 dependency is gone

@vspinu vspinu changed the title Move lubridate on top of timechane Move lubridate on top of timechange Oct 31, 2022
@vspinu
Copy link
Member Author

vspinu commented Oct 31, 2022

@DavisVaughan @hadley I have in plan to merge this tomorrow as I am pressed by a CRAN deadline on a deadline now.

This change fixes a number of critical issues, simplifies lubridate's code and streamlines DST and leap logic throughout the package. So if it really comes to porting lubridate on top of clock some day it would be much easier to do it from this new state.

@hadley
Copy link
Member

hadley commented Nov 1, 2022

If you need to get this out for a CRAN release, go for it, but I'd like us to find some time to chat about lubridate in the future. In particular, for these changes needed by CRAN fixes you should feel free to ping me or Davis for help because we normally have to fix them for many packages so it's normally pretty easy for us (plus we're paid to do this full time).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants