Skip to content

Implement venue = "discord" #474

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

mrcaseb
Copy link

@mrcaseb mrcaseb commented Nov 19, 2024

This implements #402 and while working on it I realized that I can fix #473

This PR

@mrcaseb
Copy link
Author

mrcaseb commented Nov 19, 2024

Here is a reprex of the discord venue

reprex::reprex_dircord(
  x = {
    library(ggplot2)
    ggplot(mtcars, aes(disp, qsec)) +
      geom_point()
  }
)

Output:

library(ggplot2)
ggplot(mtcars, aes(disp, qsec)) +
  geom_point()

https://i.imgur.com/LEndv9l.png

@mrcaseb
Copy link
Author

mrcaseb commented Nov 19, 2024

test-input.R L9 fails. It seems like the snapshot doesn't expect curly brackets? Seems unrelated to this PR?

Here's a screenshot from interactive review

image

I could accept the new snapshot but I don't know if you all want me to do so

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simplify_image_links() fails to simplify because of unexpected html comment strings
1 participant