-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Switched PBRemoteProgressSheet to PBTask #4
Switched PBRemoteProgressSheet to PBTask #4
Conversation
Task with lots of output would block when their pipe would get full. Drain our side of the pipe from time to time so the task can continue tasking. Ref gitx#97
We might get the termination/completion notification before we actually had a chance to read anything, so we would reallocate `standardOutputData` under the readability handler.
I'm really sorry. That last commit is "unwanted", because it's likely to conflict with my I'd gladly integrate the other two in my "branch mess" though, so ❤️ for that. If you want to help still, here are a few pointers :
So 1) should be complete (modulo bugs), 2) is "in-progress", 3) is in need of testing/moving around/fixing whatever is broken with document-handling (things like the age-old window restoration bug, the recent document controller that nobody ever sees, etc.), 4) should be complete and just needs some testing. Again, I'm really sorry for not having that "upstream", but it's all a bunch of pretty large changes, and I'm not keen on having a broken master (even though it's generally quite usable, because at some time I was running on top of that fix/sheets branch without any evident issues). |
1e0abc0
to
85909e5
Compare
I gave this branch a try and switched PBRemoteProgressSheet to use PBTask while I was trying it out.
It also seems like the
readDataToEndOfFile
calls in PBTask are unnecessary since the readabilityHandler will read the data. They were throwing exceptions for me when a PBTask was run.