"alt-z" should not be undo with Windows+Polish keyboard

[jamis]

If you have Windows set to use the "Polish (programmer)" keyboard layout, you expect "alt+z" to insert "ż" (z with a dot over it). But wysihtml5 always maps alt+z to "undo", regardless of the default behavior.

This is happening in undo_manager.js in the "keydown" event handler, here: https://github.com/xing/wysihtml5/blob/master/src/undo_manager.js#L42-58

I'm not confident enough about the side-effects to say what the correct fix here is; maybe avoid mapping meta+z to "undo" when the platform is Windows?

[tiff]

Expect that to be fixed tonight! :)

[tiff]

Hey jamis, please check my changes (you have to locally execute "make" first to compile a new wysihtml5.js). Thanks! Ping me if this is still not fixed.

[jamis]

Fantastic! I'm drowning in deadlines today and tomorrow, but I'll try and give this a test by Friday. Thanks for your quick response on this!

[qrush]

Hey @tiff, not seeing this fixed and I just deployed the latest rev here. Maybe we need to check for !event.altKey here:

https://github.com/xing/wysihtml5/blob/master/src/undo_manager.js#L48

[tiff]

Thanks @qrush. I just fired up my old windows pc and tested it. It's not about the meta key + Z as @jamis said. Instead it's about AltGr + Z which sets event.ctrlKey and event.altKey to true. I think I fixed it now finally by checking whether the alt key is pressed.

[qrush]

Awesome, I'll give it another shot on our end. Thanks immensely for your awesome work!