Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add validation to Enabled/Disabled fields in ApplicationLayer #3483

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tmjd
Copy link
Member

@tmjd tmjd commented Aug 29, 2024

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

Copy link
Member

@caseydavenport caseydavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (you could also add the kubebuilder tags to the enum type definition instead and then the validation will be inherited everywhere those types are used. I don't think it is functionally different in this case, though)

@radTuti radTuti modified the milestones: v1.36.0, v1.36.1 Oct 28, 2024
@caseydavenport caseydavenport modified the milestones: v1.36.1, v1.37.0 Oct 28, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants