Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Charges List UI Updates #31

Merged
merged 4 commits into from
Jul 26, 2021
Merged

Charges List UI Updates #31

merged 4 commits into from
Jul 26, 2021

Conversation

faxblaster
Copy link
Contributor

Makes status codes a little easier to understand at a glance, by adding colors for each status. Also adds refunded in the status column (even though it isn't strictly a status). Refunded transactions will always have a status with a value of succeeded, which seemed confusing to me. This approach made the most sense to me visually, but I'm totally open to feedback.

Screen Shot 2021-07-19 at 5 02 05 PM

@faxblaster faxblaster requested a review from mattstauffer July 19, 2021 21:18
Copy link
Member

@mattstauffer mattstauffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! I have a minor suggestion that may not actually be better? You can implement it and merge this or ignore it and merge this :)

Co-authored-by: Matt Stauffer <mattstauffer@users.noreply.github.com>
@faxblaster faxblaster merged commit a32c6fa into main Jul 26, 2021
@faxblaster faxblaster deleted the alk/add-info-to-list branch July 26, 2021 21:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants