Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow empty MySQL password #115

Merged

Conversation

thecrypticace
Copy link
Contributor

fixes #96

@mattstauffer
Copy link
Member

@thecrypticace Thanks so much! @josecanhelp and I had talked about this a bit, and I was thinking I'd rather instead have the default password be null, and if you hit enter you just get a null password. I don't love the idea of magic strings. You can either update this PR for that, or I can close it and write that code myself. Let me know. Thanks!!

@thecrypticace thecrypticace force-pushed the feature/mysql-empty-password branch from af650b7 to e920129 Compare September 14, 2020 01:28
@thecrypticace thecrypticace force-pushed the feature/mysql-empty-password branch from e920129 to 1095c6f Compare September 14, 2020 01:29
@thecrypticace
Copy link
Contributor Author

Updated!

Copy link
Contributor

@josecanhelp josecanhelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this out locally and it all looks good! Thanks!

@josecanhelp josecanhelp merged commit ce104b8 into tighten:main Sep 14, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for null password for MySQL
3 participants