Return right container name when a docker run fail. #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/Shell/Docker.php
Outdated
Comment on lines
123
to
125
| $containerName = array_key_exists('container_name', $parameters) ? $parameters['container_name'] : ''; | ||
| $imageName = $parameters['image_name']; | ||
| throw new Exception("Failed installing {$imageName}. The container {$containerName} is already in use."); |
There was a problem hiding this comment.
Suggested change
| $containerName = array_key_exists('container_name', $parameters) ? $parameters['container_name'] : ''; | |
| $imageName = $parameters['image_name']; | |
| throw new Exception("Failed installing {$imageName}. The container {$containerName} is already in use."); | |
| throw new Exception("Failed installing {$parameters['imageName']}."); |
There was a problem hiding this comment.
It's more generic. I can change my PR if you want 😃
|
Thanks @danielebarbaro! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mattstauffer, i found and fix this:
