Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix incorrect capital letter in class name #46

Merged
merged 2 commits into from
Sep 12, 2022

Conversation

jacksleight
Copy link
Contributor

The PhpSpellcheck\Spellchecker namespace is Spellchecker with a lowercase c. The docs have it with a capital. On case-sensitive filesystems this results in a "Class doesn't exist" error as Composer can't find the file.

@jacksleight jacksleight changed the title Update 02_Quick_Start.md Fix incorrect capital letter in class name Sep 9, 2022
@tigitz
Copy link
Owner

tigitz commented Sep 10, 2022

Thanks, nice catch. I'll check if there aren't any other docs affected and merge it.

Unless you're open to proceed to do the check yourself 😊

Let me know.

@jacksleight
Copy link
Contributor Author

Sure thing, will take a look.

@jacksleight
Copy link
Contributor Author

Looks like the quick start page was the only place that had SpellChecker, I've just run the generate docs script to update the html files as well.

@tigitz tigitz merged commit 355e161 into tigitz:master Sep 12, 2022
@tigitz
Copy link
Owner

tigitz commented Sep 12, 2022

Awesome ! You even went through my custom frankensteinish doc generation script to make it happen.

Many thanks @jacksleight for your time and contribution. Hope the package will be useful to you.

@jacksleight jacksleight deleted the patch-1 branch September 12, 2022 13:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants