-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add flash script for each target artifacts #81
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: mnokka-unikie <mika.nokka@unikie.com>
Please fix inconsistent indentation and formatting |
This seems overly complicated to me. If it's the same flash script for all of those targets, wouldn't it be far simpler if just copied the script (once) to the root of the build artifacts, e.g. here: https://ghaf-jenkins-controller-prod.northeurope.cloudapp.azure.com/artifacts/ghaf-main-pipeline/build_12-commit_147f806264d2fb9d9026d4221b7cfbd69587bb61/, instead of placing it inside each target artifact directory? |
Testers wanted to have copy in each target directory ("just one script copy approach was offered"). They "approved" the current solution, hence now we have development vs. user acceptance phenomena |
Hello from the testing team (& also from the user trials point of view) Having a separate script for each target makes it a lot more easier to use. In the testing side we for sure could deal with that, but we also have now user trial participants that are using Artifacts. Many of them don't know what the different targets are or how Jenkins folders work. When the script is in the same folder as the image, we can just send one link and everything needed will be there. |
If flashing scripts are something, we should also provide to end users, then they should also be part of target build output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposing to close this with the alternative resolution @mkaapu referenced above
Adding flash script to each but docs target artifiact directory