Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Some key are not replaced in log #8419

Closed
rleungx opened this issue Jul 18, 2024 · 0 comments · Fixed by #8415
Closed

Some key are not replaced in log #8419

rleungx opened this issue Jul 18, 2024 · 0 comments · Fixed by #8415
Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug.

Comments

@rleungx
Copy link
Member

rleungx commented Jul 18, 2024

Bug Report

What did you do?

Set enable-redact-log to true

What did you expect to see?

All key in the log should be replaced with ?

What did you see instead?

[2024/07/18 11:32:59.548 +08:00] [INFO] [keyspace.go:383] ["[keyspace] added region label for keyspace"] [keyspace-id=0] [label-rule="{\"id\":\"keyspaces/0\",\"index\":0,\"labels\":[{\"key\":\"id\",\"value\":\"0\"}],\"rule_type\":\"key-range\",\"data\":[{\"start_key\":\"7200000000000000fb\",\"end_key\":\"7200000100000000fb\"},{\"start_key\":\"7800000000000000fb\",\"end_key\":\"7800000100000000fb\"}]}"] [takes=1.505851ms]
[2024/07/18 11:32:59.787 +08:00] [INFO] [cluster_worker.go:248] ["region batch split, generate new regions"] [region-id=12] [origin="id:14 end_key:\"748000FFFFFFFFFFFFF900000000000000F8\" region_epoch:<conf_ver:1 version:7 > peers:<id:15 store_id:1 >"] [total=1]

What version of PD are you using (pd-server -V)?
@rleungx rleungx added the type/bug The issue is confirmed as a bug. label Jul 18, 2024
@rleungx rleungx mentioned this issue Jul 18, 2024
Merged
@rleungx rleungx added affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. labels Jul 18, 2024
@ti-chi-bot ti-chi-bot bot closed this as completed in 2d8e03f Jul 19, 2024
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jul 22, 2024
@rleungx @ti-chi-bot
This is an automated cherry-pick of tikv#8415
c1b8865 
close tikv#8419

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this issue Jul 22, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this issue Jul 22, 2024
@ti-chi-bot @rleungx
*: fix redact log (#8415) (#8425)
6974ec5 
close #8419

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot mentioned this issue Jul 31, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this issue Jul 31, 2024
@ti-chi-bot @rleungx
*: fix redact log (#8415) (#8472)
1f5e9b6 
close #8419

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ryan Leung <rleungx@gmail.com>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Aug 27, 2024
@rleungx @ti-chi-bot
This is an automated cherry-pick of tikv#8415
4577eeb 
close tikv#8419

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Aug 27, 2024
Merged
Merged
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Aug 27, 2024
@rleungx @ti-chi-bot
This is an automated cherry-pick of tikv#8415
dfda826 
close tikv#8419

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this issue Aug 27, 2024
@ti-chi-bot @HuSharp
*: fix redact log (#8415) (#8570)
50769c6 
close #8419

Signed-off-by: husharp <ihusharp@gmail.com>

Co-authored-by: husharp <ihusharp@gmail.com>
ti-chi-bot bot added a commit that referenced this issue Aug 28, 2024
@ti-chi-bot @rleungx @ti-chi-bot
*: fix redact log (#8415) (#8571)
7904d55 
close #8419

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ryan Leung <rleungx@gmail.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug.
Projects
Questions and Bug Reports
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: fix redact log rleungx/pd
1 participant
@rleungx